-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.1.4 patch updates #573
7.1.4 patch updates #573
Conversation
…e#567) We have this of the package name. It only outputs that the current one is bad, not what the current one actually is. Added an output of the current one to the error.
(subdirectories) such as "appco", with unit tests to verify Needed for @katzer plugins that use de/appplant subdirectory, for example: * cordova-plugin-local-notifications * cordova-plugin-badge * cordova-plugin-background-mode Also needed for cordova-plugin-inappbrowser Co-authored-by: Christopher J. Brody <chris.brody@gmail.com> Co-authored-by: Julio César <jcesarmobile@gmail.com> Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 7.1.x #573 +/- ##
=======================================
Coverage 44.63% 44.63%
=======================================
Files 17 17
Lines 1705 1705
Branches 316 316
=======================================
Hits 761 761
Misses 944 944
Continue to review full report at Codecov.
|
Sure that you want to include the dep updates? Besides that: let's get this out as fast as possible. |
Can you please release it? Thanks! |
We're trying to run some additional tests to catch any other potential issues, and figuring out whether we can do an accelerated release. A typical release takes at least 2 days due to a mandatory 48-hour voting period on the mailing list (as per Apache Software Foundation rules). |
On Thu, Nov 22, 2018, 10:38 AM Jan Piotrowski ***@***.***> wrote:
Sure that you want to include the dep updates?
I had wanted to get the patch update at least for android-versions, which
was done its own commit. I think this should be valid for a patch release,
any other feedback would be welcome. I can take the patch updated out if
you want.
Besides that: let's get this out as fast as possible.
I will make the release for review vote in 2-3 hours, going out to lunch
with family now. I'm fine if someone else wants to make it sooner.
… |
I reverted 5a5f544 to remove "some other minor dependencies updates" from upcoming patch release, rationale is in 84cb08b. (I discovered had missed a duplicated dependency, further explanation is in 84cb08b.) I did the revert in a direct manner in order to unblock the 7.1.4 release. Note that neither the 5a5f544 updates nor the revert will show up in the Also note that the android-versions@1.4.0 update was in its own commit, not reverted. |
1.4.0
(seems to add support for Android Pie)Some other minor dependencies updates in 7.1.x(reverted with explanation in 84cb08b)If approved, I would like to merge later today and make a 7.1.4 patch release.