Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (eslint): use cordova-eslint #910

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 29, 2020

Motivation and Context

Code syntax cleanup

apache/cordova#142

Description

  • replace dependencies with @cordova/eslint-config
  • update eslint config
  • eslint corrections

Testing

  • npm t
  • npm run eslint

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 9.0.0 milestone Jan 29, 2020
@erisu erisu requested a review from breautek January 29, 2020 07:06
@erisu erisu requested a review from dpogue January 29, 2020 07:07
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #910 into master will not change coverage.
The diff coverage is 53.19%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   65.94%   65.94%           
=======================================
  Files          21       21           
  Lines        1850     1850           
=======================================
  Hits         1220     1220           
  Misses        630      630
Impacted Files Coverage Δ
bin/templates/cordova/lib/retry.js 100% <ø> (ø) ⬆️
bin/templates/cordova/lib/android_sdk.js 100% <ø> (ø) ⬆️
bin/templates/cordova/lib/pluginHandlers.js 87.33% <ø> (ø) ⬆️
...n/templates/cordova/lib/builders/ProjectBuilder.js 71.97% <0%> (ø) ⬆️
bin/templates/cordova/lib/utils.js 17.85% <0%> (ø) ⬆️
bin/templates/cordova/lib/build.js 31.61% <100%> (ø) ⬆️
bin/lib/create.js 93.87% <100%> (ø) ⬆️
...lates/cordova/lib/config/GradlePropertiesParser.js 76.66% <100%> (ø) ⬆️
bin/templates/cordova/lib/emulator.js 89.83% <100%> (ø) ⬆️
bin/templates/cordova/lib/check_reqs.js 51.2% <25%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6372ca3...a6b4886. Read the comment docs.

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Code looks good to me. npm run lint works. Building an with this version works.

bin/templates/cordova/lib/android_sdk.js Show resolved Hide resolved
@erisu erisu merged commit de105e8 into apache:master Jan 31, 2020
@erisu erisu deleted the feat/eslint branch January 31, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants