Create shareable ESLint config and use it throughout our repos

[raphinesse]

Feature Request

Motivation Behind Feature

This would make it easier to enforce consistency in our code style while allowing for controlled refinement of it at the same time.

This could also reduce the amount of ESLint related dependencies in the individual repos, if we just require the plugins and base configuration we need in the new shareable config package.

Feature Description

• Create a ESLint shareable config
• Use it in our repos

Implementation Progress

Platforms

• cordova-android
• cordova-browser (breaking: @cordova/eslint-config w/ applied fix cordova-browser#96)
• cordova-electron (refactor: eslint setup cordova-electron#113)
• cordova-ios
• cordova-osx
• cordova-test-platform
• cordova-windows

Plugins

• cordova-plugin-battery-status
• cordova-plugin-camera
• cordova-plugin-device (refactor(eslint): use cordova-eslint  cordova-plugin-device#122)
• cordova-plugin-dialogs (refactor(eslint): use cordova-eslint /w fix cordova-plugin-dialogs#141)
• cordova-plugin-file (refactor: shared eslint config cordova-plugin-file#458)
• cordova-plugin-geolocation (refactor(eslint): use cordova-eslint /w fix cordova-plugin-geolocation#200)
• cordova-plugin-inappbrowser
• cordova-plugin-media (refactor(eslint): use cordova-eslint /w fix cordova-plugin-media#283)
• cordova-plugin-media-capture (refactor(eslint): use cordova-eslint /w fix cordova-plugin-media-capture#179)
• cordova-plugin-network-information
• cordova-plugin-screen-orientation (refactor(eslint): use cordova-eslint /w fix cordova-plugin-screen-orientation#66)
• cordova-plugin-splashscreen
• cordova-plugin-statusbar (refactor(eslint): use cordova-eslint cordova-plugin-statusbar#194)
• cordova-plugin-vibration (refactor(eslint): use cordova-eslint /w fix cordova-plugin-vibration#89)
• cordova-plugin-whitelist (Deprecated)
• cordova-plugin-wkwebview-engine (refactor(eslint): use cordova-eslint /w fix cordova-plugin-wkwebview-engine#164)
• cordova-plugin-device-motion
• cordova-plugin-device-orientation
• cordova-plugin-file-transfer

Tooling

• cordova-cli (refactor: eslint setup cordova-cli#493)
• cordova-coho
• cordova-common (refactor: eslint setup cordova-common#105, chore: consolidate eslint configs cordova-common#109)
• cordova-create (refactor: eslint setup cordova-create#54, chore: eslint config cleanup cordova-create#55)
• cordova-docs
• cordova-fetch (refactor: eslint setup cordova-fetch#70, chore: consolidate eslint configs cordova-fetch#81)
• cordova-js
• cordova-lib (refactor: eslint setup cordova-lib#822, chore: consolidate eslint configs cordova-lib#828)
• cordova-mobile-spec
• cordova-node-xcode
• cordova-paramedic
• cordova-plugin-test-framework
• cordova-plugman
• cordova-serve (refactor: eslint setup cordova-serve#23, chore: consolidate eslint configs cordova-serve#25)

Excluded:

• cordova-status
• cordova
• cordova-app-hello-world

and any unused, outdated, or deprecated repos_

[raphinesse]

Step one is done. We created cordova-eslint.

Step two is in progress. @erisu do we have another issue where we track the progress on this task? If not, we should probably do it here.

[erisu]

As far as I can remember, there is no ticket that covers tracking of adding the new package to each repo.

I will update this ticket's description to include a list of repos to keep track of progress. If you like to move to a separate ticket we can copy the content over.

[raphinesse]

I guess we have to add the plugins from #243 to the Todo list?

[timbru31]

Already done ;)
(Edit: The migration to ESLint, not adding them to the list above)

[raphinesse]

Already done ;)
(Edit: The migration to ESLint, not adding them to the list above)

Great! Thanks for letting me know.

[raphinesse]

Should we add the hacktoberfest label for the remaining Todos? Some of them might be a bit out of the ordinary 🤔