Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(eslint): use cordova-eslint /w fix #66

Merged
merged 1 commit into from
Jul 2, 2020
Merged

refactor(eslint): use cordova-eslint /w fix #66

merged 1 commit into from
Jul 2, 2020

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Jul 1, 2020 •
edited
Loading

Motivation and Context

Consistent codebase.

Ref apache/cordova#142
Ref apache/cordova#4
Closes #51
Closes #50

Depends on #65, WIP until merged.

@janpio janpio mentioned this pull request Jul 1, 2020
Open
39 tasks
@raphinesse raphinesse mentioned this pull request Jul 1, 2020
Open
40 tasks
erisu
erisu approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

The only comment is that I noticed the package-lock.json task is also completed under this PR. Others had told me in the past to separate this change in its own PR.

@timbru31 timbru31 mentioned this pull request Jul 2, 2020
Merged
@timbru31 timbru31 changed the title WIP: refactor(eslint): use cordova-eslint /w fix refactor(eslint): use cordova-eslint /w fix Jul 2, 2020
@timbru31 timbru31 marked this pull request as ready for review July 2, 2020 08:26
@timbru31 timbru31 merged commit 57df018 into master Jul 2, 2020
@timbru31 timbru31 deleted the feat/eslint branch July 2, 2020 10:12
@mkranz mkranz mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert to eslint
2 participants
@timbru31 @erisu