Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: eslint setup #822

Merged
merged 2 commits into from
Nov 15, 2019
Merged

refactor: eslint setup #822

merged 2 commits into from
Nov 15, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 14, 2019

Description

  • replace eslint dependencies with @cordova/eslint-config
  • update eslint config
  • eslint corrections

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #822 into master will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #822   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          46       46           
  Lines        2150     2150           
=======================================
  Hits         1923     1923           
  Misses        227      227
Impacted Files Coverage Δ
src/plugman/platform.js 20% <ø> (ø) ⬆️
src/plugman/util/default-engines.js 100% <ø> (ø) ⬆️
src/plugman/fetch.js 86.06% <ø> (ø) ⬆️
src/cordova/restore-util.js 93.95% <ø> (ø) ⬆️
src/plugman/uninstall.js 93.46% <ø> (ø) ⬆️
src/plugman/platform_operation.js 66.66% <0%> (ø) ⬆️
src/cordova/targets.js 19.23% <0%> (ø) ⬆️
src/plugman/create.js 91.42% <0%> (ø) ⬆️
src/cordova/serve.js 100% <100%> (ø) ⬆️
src/cordova/plugin/add.js 98.65% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144314c...d6ba01d. Read the comment docs.

* replace dependencies with @cordova/eslint-config
* update eslint config
* eslint corrections
.eslintrc.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants