Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct linter command in Readme #877

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Aug 19, 2021

Platforms affected

Docs

Motivation and Context

The command to lint described in Readme file does not follow the changes introduced in #822.

Description

Correct with "lint" NPM script like in package.json.

Testing

.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #877 (4e71f55) into master (3274a78) will not change coverage.
The diff coverage is n/a.

❗ Current head 4e71f55 differs from pull request most recent head d68b8d0. Consider uploading reports for the commit d68b8d0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          45       45           
  Lines        2053     2053           
=======================================
  Hits         1871     1871           
  Misses        182      182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3274a78...d68b8d0. Read the comment docs.

@raphinesse raphinesse merged commit dd872f0 into apache:master Aug 20, 2021
@raphinesse
Copy link
Contributor

Thanks for fixing this! 🎉

@ath0mas ath0mas deleted the patch-1 branch August 20, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants