Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (eslint): use cordova-eslint #282

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 14, 2021

Motivation and Context

Code syntax cleanup

apache/cordova#142

Description

  • replace dependencies with @cordova/eslint-config
  • update eslint config
  • eslint corrections

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu requested a review from raphinesse July 14, 2021 17:21
@erisu
Copy link
Member Author

erisu commented Jul 14, 2021

In a later PR, will deal with replacing the url.parse() with new URL() and test various use cases.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #282 (f966c03) into master (3e0b4f6) will not change coverage.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files           8        8           
  Lines         495      495           
=======================================
  Hits          292      292           
  Misses        203      203           
Impacted Files Coverage Δ
src/gitutil.js 27.65% <0.00%> (ø)
src/versionutil.js 56.57% <0.00%> (ø)
src/repoutil.js 68.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0b4f6...f966c03. Read the comment docs.

@erisu erisu merged commit 4f4b486 into apache:master Jul 15, 2021
@erisu erisu deleted the chore/update-eslint branch July 15, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants