remove no-throw-literal lint exception not needed

[brodycj]

UPDATED:

• Updated the title
• keeping the custom no-unused-vars entry, as requested in the discussion below
• rebased on master with force-push after merge of PR Fix ESLint violations where applicable #83

As there is desire to keep the custom no-unused-vars entry, there seems to be only one exception that we can remove without updating the code. This is why I updated the title and force-pushed the change with the updated commit message.

[janpio]

This file is usually copied over to all the projects to enforce a standard that is valid across all our projects. Removing individual rules here that don't apply to this project will break that.

But if this really is a change in how we want to write our code in general, and there is a good reason behind it, this is of course fine - but it should be explained then.

[raphinesse]

@janpio Actually, this file isn't consistent across all projects AFAIK. As a matter of fact, I added the no-unused-vars rule here (and only here) myself.

However, I agree that it would be great to enforce a consistent code style across all projects. But we should not do that by copying .eslintrc files but rather by having a Cordova ESLint config package that is required by all repos. I've had that on my mental to do list for quite some time but didn't get around to creating an issue for it.

[raphinesse]

no-unused-vars is a very useful addition IMHO. In fact I added it myself IIRC.

OTOH, removing the disabling of no-throw-literal would be more than fine with me.

[raphinesse]

@janpio See apache/cordova#142

[brodycj]

I just updated the title and force-pushed the change to remove the single no-throw-literal exception. Thanks @raphinesse for reviewing and raising apache/cordova#142 in response.

A quick review would be really appreciated.

P.S. I see that @raphinesse added no-unused-vars with the args: after-used setting in 8d6511e. I would love to see this in Standard JS itself, will raise a proposal for upcoming version 14.