Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

breaking: @cordova/eslint-config w/ applied fix #101

Merged
merged 7 commits into from
Jun 15, 2020
Merged

breaking: @cordova/eslint-config w/ applied fix #101

merged 7 commits into from
Jun 15, 2020

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Jun 13, 2020

Platforms affected

OSX

Motivation and Context

Use consistent eslint rules with other projects

Description

Add Cordova eslint config and fixed lint warnings

Please check eslint config and command. I am not an expert with this

Closes #64

Testing

npm test and CI

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   39.34%   39.34%           
=======================================
  Files           5        5           
  Lines         427      427           
=======================================
  Hits          168      168           
  Misses        259      259           
Impacted Files Coverage Δ
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 6.62% <ø> (ø)
bin/lib/create.js 76.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17a463...3dbfc6c. Read the comment docs.

@NiklasMerz NiklasMerz added this to the 6.0.0 milestone Jun 13, 2020
Copy link
Member Author

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new changes LGTM 👍

@NiklasMerz NiklasMerz merged commit 0168cf3 into master Jun 15, 2020
@NiklasMerz NiklasMerz deleted the eslint branch June 15, 2020 14:31
@timbru31
Copy link
Member

Part of apache/cordova#142, too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use const whenever possible
4 participants