Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated eslint with applied fix #744

Merged
merged 5 commits into from
Dec 17, 2019
Merged

chore: updated eslint with applied fix #744

merged 5 commits into from
Dec 17, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 17, 2019 •
edited
Loading

Motivation and Context

Code syntax cleanup

apache/cordova#142

Description

  • replace dependencies with @cordova/eslint-config
  • update eslint config
  • eslint automatic and manual corrections

This PR require #743 to be merged first.

Testing

  • npm t
  • npm run lint

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Dec 17, 2019
raphinesse
raphinesse requested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for two minor issues.

.eslintrc.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@erisu erisu requested a review from raphinesse December 17, 2019 21:32
erisu and others added 5 commits December 18, 2019 06:46
@erisu
chore: eslint update w/ automated applied fixes
d0c4353
@erisu
chore: eslint manual applied fixes
f569d1c
@erisu @raphinesse
Update package.json
f59f63a 
Co-Authored-By: Raphael von der Grün <raphinesse@gmail.com>
@erisu @raphinesse
Update .eslintrc.yml
4ad25a2 
Co-Authored-By: Raphael von der Grün <raphinesse@gmail.com>
@erisu
chore: applied lint to bin
6467ac8
raphinesse
raphinesse approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 5ff2c6c into apache:master Dec 17, 2019
@erisu erisu deleted the v6-eslint branch February 25, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphinesse raphinesse raphinesse approved these changes

@dpogue dpogue Awaiting requested review from dpogue

@jcesarmobile jcesarmobile Awaiting requested review from jcesarmobile

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @raphinesse