-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve patch release support #176
Conversation
695f034
to
9368992
Compare
de6dac4
to
cc881c5
Compare
Added |
- prepare-platform-release-branch add options: - [-b <platform branch name>] - [--js <cordova-js branch or tag name>] - copy-js add option: - [--js <cordova-js branch or tag name>]
and fix tag-release usage
needed for cordova-osx (4.0.2-dev) & cordova-windows FUTURE TBD can we think of a better fix?
cc881c5
to
efb4bd8
Compare
according to recent changes: - usage with non-master release branch - tag without automatic push
efb4bd8
to
82650a2
Compare
Is this PR ready to be reviewed? If not, please prefix the PR title with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it would be beneficial if the different changes (new options, usage messages/docs, CDVAvailability.h, workarounds) were in clean, separate PRs.
Closing in favor of changes in #188 which is in WIP state. |
Platforms affected
All
What does this PR do?
Updates to improve support for patch releases:
prepare-platform-release-branch
add options:[-b <platform branch name>]
[-js <cordova-js branch or tag name>]
copy-js
add option:[-js <cordova-js branch or tag name>]
Enables the following:
copy-js
andcoho prepare-platform-release-branch
, without extremely ugly workaround solutionOther changes included:
CDVAvailability.h
after updating JS in git (more sensical order)CDVAvailability.h
if version number ends with non-numerical character, needed to avoid build error in case of marking -dev versionWhat testing has been done on this change?
Tested on
4.5.x
branch in my fork of cordova-ios, results in cb-4.5.x-coho-patch-update-test tree of my fork of cordova-ios:./cordova-coho/coho prepare-platform-release-branch -r ios --version 4.5.5-dev -b 4.5.x --js 4.2.3
resulted in the following changes (without unwanted change toCDVAvailability.h
):4.5.5-dev
via coho (brodycj/cordova-ios@c961d77)./cordova-coho/coho copy-js -r ios --js 4.2.4
copies the actual update to cordova.js (brodycj/cordova-ios@4e53cd2)./cordova-coho/coho prepare-platform-release-branch -r ios --version 4.5.5 -b 4.5.x --js 4.2.4
results in the following changes for4.5.5
release (no not a real release):4.5.5
from cordova-js@4.2.4 (brodycj/cordova-ios@df8d7f3)4.5.5
(brodycj/cordova-ios@e134907)4.5.5
via coho (brodycj/cordova-ios@795e09e)TODO items:
.eslintrc.yml
tools-release-process.md
Checklist
Reported an issue in the JIRA databaseCommit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.