CB-14145 resolve npm audit issues in 4.5.x patch fix #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 3, 2018 19:28
update from cordova-js@4.2.4
- add Node.js 8 & 10 - show npm version - latest releases of Node.js 4 & 6 - minor cleanup
This was referenced Jul 6, 2018
Closed
Codecov Report
@@ Coverage Diff @@
## 4.5.x #379 +/- ##
=======================================
Coverage 63.45% 63.45%
=======================================
Files 14 14
Lines 1691 1691
Branches 284 284
=======================================
Hits 1073 1073
Misses 618 618Continue to review full report at Codecov.
|
brodycj
changed the title
|
Marked as WIP since I would like to include xcode@1.0.1 once it is ready with changes fro apache/cordova-node-xcode#10 to resolve [dev] audit issues there. P.S. My apologies for any possible confusion this may cause. |
shazron
approved these changes
Jul 10, 2018
added 5 commits
July 11, 2018 10:09
- add Node.js versions 8 & 10 - do normal npm install (workaround for uncrustify no longer needed)
- coffee-script - uncrustify
according to versions in node_modules
updates to resolve npm audit issues: - cordova-common@2.2.5 - ios-sim@6.1.3 - plist@2.1.0
brodycj
changed the title
added 3 commits
July 11, 2018 11:43
items not needed (4.5.x): - node_modules/.bin (all contents) - node_modules/pegjs - package-lock.json
as installed by the following command on npm@6.1.0:
npm i --only=production
(needed to support deprecated Node.js 4 version)
(indirect production dependencies needed by deprecated Node.js 4.x)
|
Merged with a few additional changes:
Thanks @shazron for the review. |
2 tasks
This was referenced Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
npm auditissues in this patch fix:node_modules(ignoringnode_modules/.bin) using the following command on npm@6.1.0:npm install --only=productioncordova.jsfrom cordova-js@4.2.4 with the following changes (using local coho with Improve patch release support cordova-coho#176 for patch release support):bundledDependenciesto support deprecated Node.js 4 in this patch fix.travis.ymlto test on latest version of Node.js 4 (deprecated), 6, 8, and 10 (with other minor cleanup fixes).gitignoreupdates in this patch fixappveyor.ymlto cover Node.js 8 & 10 and do normalnpm installnow that workaround foruncrustifyis no longer neededWhat testing has been done on this change?
npm run unit-testspasses on full npm install on Node.js versions 4 (deprecated), 6, 8, and 10npm auditwith npm@6.1.0 (latest version) shows 0 vulnerabilitiescordova platform add brodybits/cordova-ios#cb-14145-patchto add platform to new Cordova project and test on iOS simulator usingcordova run iossucceeds on the following Node.js versions:CI testing:
npm testand other tests pass on Travis CIunit-tests, etc. pass on AppVeyor CIChecklist
Added automated test coverage as appropriate for this change.