Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates for minor release (cordova-ios@4.6) - PENDING WIP #370

Closed
wants to merge 9 commits into from

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 13, 2018

Platforms affected

iOS

What does this PR do?

These changes resolve ugly npm audit warning messages

STATUS:

  • changes still need some cleanup
  • cordova-common update is waiting for proposed cordova-common 2.2.4 update (apache/cordova-common@27) to be accepted, integrated, and released
  • also waiting for new 4.6.x branch to be made

What testing has been done on this change?

  • npm test succeed on Travis CI
  • tested working in new cordova project using cordova plugin add brodybits/cordova-ios#cb-minor-package-updates command
  • also tested working in cordova-sqlite-storage test suite

Checklist

@brodycj brodycj force-pushed the cb-minor-package-updates branch 2 times, most recently from 55bf7b3 to 5841b2b Compare June 13, 2018 17:47
@brodycj brodycj closed this Jun 14, 2018
@brodycj
Copy link
Contributor Author

brodycj commented Jun 14, 2018

Reopening for WIP CI testing, apologies to watchers for the bother

@brodycj brodycj reopened this Jun 14, 2018
@brodycj brodycj changed the title Package updates for minor release - PENDING WIP Package updates for minor release (cordova-ios@4.6) - PENDING WIP Jun 15, 2018
@brodycj
Copy link
Contributor Author

brodycj commented Jul 6, 2018

Closing in favor of #379

@brodycj brodycj closed this Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant