Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to plist@3 WIP FOR MINOR PATCH RELEASE #367

Closed
wants to merge 4 commits into from

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 13, 2018

Platforms affected

iOS

What does this PR do?

Use plist@3 (3.0.1) dependency to help resolve an ugly NPM install warning (shows up in npm audit)

What testing has been done on this change?

  • unit test
  • tested in basic Cordova project (initialized using cordova create)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Other

I would recommend a minor version bump, may need another major version bump to be 100% sure.

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   63.99%   63.99%           
=======================================
  Files          14       14           
  Lines        1697     1697           
  Branches      286      286           
=======================================
  Hits         1086     1086           
  Misses        611      611

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd12a1...648354a. Read the comment docs.

@brodycj brodycj changed the title Update to plist@3 Update to plist@3 WIP Jun 14, 2018
@brodycj
Copy link
Contributor Author

brodycj commented Jun 14, 2018

Rebased on #371 (CI testing on Node.js 8 & 10) for WIP TESTING, will be rebased again if #371 is accepted and merged.

@brodycj brodycj changed the title Update to plist@3 WIP Update to plist@3 WIP FOR MINOR PATCH RELEASE Jun 15, 2018
@brodycj
Copy link
Contributor Author

brodycj commented Jul 23, 2018

Closing - plist@2 will be used in minor release to avoid ugly engine warning message on Node.js 4

@brodycj brodycj closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants