Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ios-sim@^7.0.0 WIP FOR MINOR PATCH RELEASE (4.6.x) #372

Closed
wants to merge 1 commit into from

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 14, 2018

Platforms affected

iOS

What does this PR do?

Upgrade to ios-sim@7

resolves a npm audit warning

What testing has been done on this change?

  • npm run unit-tests passes
  • ios-sim 7.0.0 was tested in cordova-ios project in the past

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@brodycj brodycj requested review from shazron and stevengill June 14, 2018 07:44
@codecov-io
Copy link

Codecov Report

Merging #372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   63.99%   63.99%           
=======================================
  Files          14       14           
  Lines        1697     1697           
  Branches      286      286           
=======================================
  Hits         1086     1086           
  Misses        611      611

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd12a1...20ed496. Read the comment docs.

@brodycj brodycj changed the title Update to ios-sim@^7.0.0 Update to ios-sim@^7.0.0 [MAJOR RELEASE ITEM] Jun 15, 2018
@dpogue
Copy link
Member

dpogue commented Jun 15, 2018

Isn't the plan to drop all the bundled node_modules in the next major release? We should be able to get away with just updating the version in package.json

@brodycj brodycj changed the title Update to ios-sim@^7.0.0 [MAJOR RELEASE ITEM] Update to ios-sim@^7.0.0 on minor release (4.6.x) Jun 15, 2018
@brodycj brodycj changed the title Update to ios-sim@^7.0.0 on minor release (4.6.x) Update to ios-sim@^7.0.0 on minor patch release (4.6.x) Jun 15, 2018
@brodycj brodycj changed the title Update to ios-sim@^7.0.0 on minor patch release (4.6.x) Update to ios-sim@^7.0.0 WIP FOR MINOR PATCH RELEASE (4.6.x) Jun 15, 2018
@brodycj
Copy link
Contributor Author

brodycj commented Jun 15, 2018

Isn't the plan to drop all the bundled node_modules in the next major release? We should be able to get away with just updating the version in package.json

@dpogue that is correct. I just updated the title to correctly reflect where this change should actually go. We need a 4.6.x branch before merging this one (should not hit the master branch).

@brodycj
Copy link
Contributor Author

brodycj commented Jul 6, 2018

Will be ios-sim@6.1.3 in coming patch release

@brodycj brodycj closed this Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants