Ensure test failure on unexpected promise resolution (#485)

apache · Dec 19, 2018 · fe01e5d · fe01e5d
1 parent 1d00e60
commit fe01e5d
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/tests/spec/component/versions.spec.js b/tests/spec/component/versions.spec.js
@@ -25,38 +25,40 @@ if (process.platform === 'darwin') {
     describe('versions', function () {
         describe('get_tool_version method', () => {
             it('should not have found tool by name.', (done) => {
-                versions.get_tool_version('unknown').catch((error) => {
-                    expect(error).toContain('is not valid tool name');
-                    done();
-                });
+                versions.get_tool_version('unknown')
+                    .then(() => done.fail('expected promise rejection'))
+                    .catch((error) => {
+                        expect(error).toContain('is not valid tool name');
+                        done();
+                    });
             });
 
             it('should find xcodebuild version.', (done) => {
                 versions.get_tool_version('xcodebuild').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
 
             it('should find ios-sim version.', (done) => {
                 versions.get_tool_version('ios-sim').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
 
             it('should find ios-deploy version.', (done) => {
                 versions.get_tool_version('ios-deploy').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
 
             it('should find pod version.', (done) => {
                 versions.get_tool_version('pod').then((version) => {
                     expect(version).not.toBe(undefined);
                     done();
-                });
+                }).catch(() => done.fail('expected promise resolution'));
             });
         });
     });