Ensure test failure on unexpected promise resolution #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
reviewed
Dec 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 11 11
Lines 1796 1796
=======================================
Hits 1359 1359
Misses 437 437Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 11 11
Lines 1796 1796
=======================================
Hits 1359 1359
Misses 437 437Continue to review full report at Codecov.
|
brodycj
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
It makes sure that the tests are failed correctly if the result is not as expected. Previously, these tests would simply time out after the Jasmine default timeout period. Now the tests will fail right away and give a better indication towards the reason.
What testing has been done on this change?
I've ran the tests.
Started ....F Failures: 1) versions get_tool_version method should find pod version. Message: Failed: expected promise resolution Stack: Error: expected promise resolution at versions.get_tool_version.then.catch (/Users/oliver/cordova-ios/tests/spec/component/versions.spec.js:61:37)