Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test failure on unexpected promise resolution #485

Merged
merged 1 commit into from Dec 19, 2018
Merged

Ensure test failure on unexpected promise resolution #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions tests/spec/component/versions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,38 +25,40 @@ if (process.platform === 'darwin') {
describe('versions', function () {
describe('get_tool_version method', () => {
it('should not have found tool by name.', (done) => {
versions.get_tool_version('unknown').catch((error) => {
expect(error).toContain('is not valid tool name');
done();
});
versions.get_tool_version('unknown')
.then(() => done.fail('expected promise rejection'))
.catch((error) => {
expect(error).toContain('is not valid tool name');
done();
});
});

it('should find xcodebuild version.', (done) => {
versions.get_tool_version('xcodebuild').then((version) => {
expect(version).not.toBe(undefined);
done();
});
}).catch(() => done.fail('expected promise resolution'));
});

it('should find ios-sim version.', (done) => {
versions.get_tool_version('ios-sim').then((version) => {
expect(version).not.toBe(undefined);
done();
});
}).catch(() => done.fail('expected promise resolution'));
});

it('should find ios-deploy version.', (done) => {
versions.get_tool_version('ios-deploy').then((version) => {
expect(version).not.toBe(undefined);
done();
});
}).catch(() => done.fail('expected promise resolution'));
});

it('should find pod version.', (done) => {
versions.get_tool_version('pod').then((version) => {
expect(version).not.toBe(undefined);
done();
});
}).catch(() => done.fail('expected promise resolution'));
});
});
});
Expand Down