Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: replace shelljs with fs-extra #851

Merged
merged 19 commits into from
May 27, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 16, 2020

Motivation, Context & Description

  • Remove shelljs dependency for fs-extra.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 16, 2020
@erisu erisu requested review from dpogue, timbru31 and NiklasMerz May 16, 2020 14:07
@erisu erisu force-pushed the breaking/replace-shelljs-with-fs-extra branch from a55f605 to 0d98b03 Compare May 20, 2020 02:08
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #851 into master will decrease coverage by 0.08%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
- Coverage   74.85%   74.76%   -0.09%     
==========================================
  Files          13       13              
  Lines        1742     1736       -6     
==========================================
- Hits         1304     1298       -6     
  Misses        438      438              
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/run.js 20.72% <0.00%> (-0.71%) ⬇️
bin/templates/scripts/cordova/lib/build.js 50.76% <50.00%> (ø)
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.05% <90.90%> (-0.16%) ⬇️
bin/templates/scripts/cordova/lib/check_reqs.js 46.93% <100.00%> (ø)
bin/templates/scripts/cordova/lib/prepare.js 85.67% <100.00%> (-0.04%) ⬇️
bin/templates/scripts/cordova/lib/projectFile.js 94.54% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bea75...b9b99fa. Read the comment docs.

This was referenced May 20, 2020
bin/lib/utils.js Outdated Show resolved Hide resolved
@erisu erisu force-pushed the breaking/replace-shelljs-with-fs-extra branch from 0447780 to b9b99fa Compare May 22, 2020 11:27
@erisu erisu requested a review from breautek May 22, 2020 14:02
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 8dce55f into apache:master May 27, 2020
@erisu erisu deleted the breaking/replace-shelljs-with-fs-extra branch May 27, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants