Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use superspawn #859

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented May 20, 2020

Motivation and Context

Cleanup & use only superspawn.

Requires PR #851

Description

  • Replace child_process with superspawn

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 20, 2020
@erisu erisu requested a review from timbru31 May 20, 2020 07:00
This was referenced May 20, 2020
@erisu erisu force-pushed the breaking/use-superspawn branch from 3998d83 to 48a88f9 Compare May 20, 2020 07:05
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #859 into master will decrease coverage by 0.24%.
The diff coverage is 67.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   74.76%   74.52%   -0.25%     
==========================================
  Files          13       13              
  Lines        1736     1680      -56     
==========================================
- Hits         1298     1252      -46     
+ Misses        438      428      -10     
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/run.js 20.37% <10.00%> (-0.36%) ⬇️
bin/templates/scripts/cordova/lib/build.js 50.51% <33.33%> (-0.26%) ⬇️
bin/templates/scripts/cordova/lib/Podfile.js 73.33% <50.00%> (-0.26%) ⬇️
bin/templates/scripts/cordova/lib/listDevices.js 100.00% <100.00%> (ø)
bin/templates/scripts/cordova/lib/versions.js 100.00% <100.00%> (+9.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dce55f...8d002cd. Read the comment docs.

@erisu erisu force-pushed the breaking/use-superspawn branch from 48a88f9 to 8d002cd Compare May 27, 2020 04:16
@erisu erisu merged commit c26d8b1 into apache:master May 27, 2020
@erisu erisu deleted the breaking/use-superspawn branch May 27, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants