Integrate unused CommonJS tests where applicable #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been an unused copy of [The Official Specs for CommonJS][1]
lying around in our repository for who knows how long. They needed to be
built using a python script and then manually executed in a browser.
This commit integrates all of those tests that also apply to our module
system into our existing test suite for `require` & `define`.
Adds adapted versions of the following CommonJs tests to our
`test.require.js`:
absolute, transitive, determinism, method, nested, hasOwnProperty
The hasOwnProperty test actually uncovered a bug in our module system
implementation and thus is deactivated right now.
The following CommonJS tests were not applicable to Cordova's module
system since it does not support cyclic dependencies at all:
cyclic, monkeys
The following CommonJS tests were already covered by tests in
`test.require.js`:
- missing: covered by Test#005
- relative: covered by Test#012
- exactExports: covered by multiple tests
[1]: https://github.com/commonjs/commonjs
erisu
approved these changes
Apr 28, 2019
There was a problem hiding this comment.
👍
Would like to get rid of the Test#### : from being in the it description...
This is just what I feel. Messages should be descriptive enough. If tests are dropped, injected in middle or even moved to other files or repos, it takes effort to keep the numbers. in sync.
Other then my opinion on the description, everything else looks good.
dpogue
approved these changes
Apr 28, 2019
|
@erisu Yeah, I'm very ambivalent about these test numbers. OTOH I agree with your point. OTOH, unique identifiers allow to quickly identify failing tests and find them in the source code. 🤷♂️ |
raphinesse
added a commit
that referenced
this pull request
Apr 28, 2019
One of the CommonJS tests adopted in #195 exposed a defect in Cordova's module system: When trying to define a module with a name that also is a property of Object.prototype, an exception would occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There has been an unused copy of The Official Specs for CommonJS lying around in our repository for who knows how long. They needed to be built using a python script and then manually executed in a browser.
This commit integrates all of those tests that also apply to our module system into our existing test suite for
require&define.Description
Adds adapted versions of the following CommonJs tests to our
test.require.js:The hasOwnProperty test actually uncovered a bug in our module system implementation and thus is deactivated right now.
The following CommonJS tests were not applicable to Cordova's module system since it does not support cyclic dependencies at all:
The following CommonJS tests were already covered by tests in
test.require.js:Future Work
I will follow up with a patch for the disabled
hasOwnPropertytest once this is merged.