Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate unused CommonJS tests where applicable #195

Merged
merged 1 commit into from
Apr 28, 2019

Commits on Apr 28, 2019

  1. Integrate unused CommonJS tests where applicable

    There has been an unused copy of [The Official Specs for CommonJS][1]
    lying around in our repository for who knows how long. They needed to be
    built using a python script and then manually executed in a browser.
    This commit integrates all of those tests that also apply to our module
    system into our existing test suite for `require` & `define`.
    
    Adds adapted versions of the following CommonJs tests to our
    `test.require.js`:
    
        absolute, transitive, determinism, method, nested, hasOwnProperty
    
    The hasOwnProperty test actually uncovered a bug in our module system
    implementation and thus is deactivated right now.
    
    The following CommonJS tests were not applicable to Cordova's module
    system since it does not support cyclic dependencies at all:
    
        cyclic, monkeys
    
    The following CommonJS tests were already covered by tests in
    `test.require.js`:
    
    - missing: covered by Test#005
    - relative: covered by Test#012
    - exactExports: covered by multiple tests
    
    [1]: https://github.com/commonjs/commonjs
    raphinesse committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    c0de95c View commit details
    Browse the repository at this point in the history