Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

ESLint Dependencies Update, Configure and Corrections #61

Merged
merged 6 commits into from
Sep 14, 2018

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 14, 2018

Platforms affected

none

What does this PR do?

  • Upgrades eslint related dependencies
  • Updates eslint configurations
  • Fixes files that did not follow eslint configured standards

What testing has been done on this change?

  • npm run eslint

@erisu erisu changed the title Eslint improvement ESLint Dependencies Update, Configure and Corrections Sep 14, 2018
@brodycj
Copy link

brodycj commented Sep 14, 2018

Looks good, adding reference to WIP PR #49 where I think most of these changes are coming from.

@brodycj brodycj merged commit e0d532c into apache:master Sep 14, 2018
@brodycj
Copy link

brodycj commented Sep 14, 2018

Merged in a merge commit since I think these changes should be kept separate in the git history.

@brodycj
Copy link

brodycj commented Sep 14, 2018

P.S. A major cleanup TODO item is to use const whenever possible, kinda wish we did this to the var declarations that we touched in this PR.

@janpio
Copy link
Member

janpio commented Sep 14, 2018

Create an issue in apache/cordova so this can be tracked and doesn't get lost in the comments of a already merged PR @brodybits

@erisu
Copy link
Member Author

erisu commented Sep 14, 2018

@brodybits I am preparing a third PR and hopefully will submit tomorrow (JST). That will contain adding code coverage dependency, a minor folder structure change around test specs for better organization, and also a minor refactor of the test code. Refactor will cover const, let, and arrow functions if possible. etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants