This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated |
Sounds good to me -- don't forget the major version update |
Good point @shazron!
|
brodycj
changed the title
Package update WIP FOR DISCUSSION
Package update WIP FOR DISCUSSION [MAJOR RELEASE ITEM]
Jun 15, 2018
+1 |
2 tasks
brodycj
changed the title
Package update WIP FOR DISCUSSION [MAJOR RELEASE ITEM]
[WIP] Package update - MAJOR RELEASE WIP
Jul 29, 2018
Recent updates (see description):
|
brodycj
changed the title
[WIP] Package update - MAJOR RELEASE WIP
[WIP] Major release TODO WIP
Aug 13, 2018
6 tasks
This was referenced Sep 12, 2018
Merged
This was referenced Sep 14, 2018
erisu
added a commit
that referenced
this pull request
Sep 14, 2018
Cherry Picks from (#49) * package.json drop uncrustify from devDependencies * package*.json remove coffee-script * package*.json remove nodeunit devDep
brodycj
force-pushed
the
cb-update-wip1
branch
from
September 14, 2018 16:43
ef506fd
to
43b98c0
Compare
Cherry Picks from apacheGH-49 (apache#49) * package.json drop uncrustify from devDependencies * package*.json remove coffee-script * package*.json remove nodeunit devDep
with some eslint rules ignored for now
brodycj
force-pushed
the
cb-update-wip1
branch
from
September 14, 2018 16:59
43b98c0
to
2ff2121
Compare
@brodybits If you want to try and finish this PR for release please do. If there isn't much time, I have a PR (#83) prepared for next release. There were some overlapped items but I just ran the same scripts that I run across all other platforms for preparations. |
Closing this PR as the changes are in master and the latest major release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
macOS ("osx")
What does this PR do?
remove(now done innode_modules
from repomaster
branch)drop(now done inuncrustify
as well ascoffee-script
&nodeunit
from devDependencies (evidently not needed)master
branch)migrate from jasmine-node to jasmine(now done inmaster
branch)upgrade the following dependencies & devDependencies:(now done inmaster
branch)cordova-common
xcode
ref: xcode 1.0.0 dependency update #48eslint
nodeunit
remove(now done inbundledDependencies
master
branch)explicitly add(moved to a separate PR)plist@3
depupdate(now done injasmine
&tmp
devDepsmaster
branch)remove outdated(now done intests/.jshintrc
master
branch)master
brancheslint TODO item(s):
tests/CordovaLibTests/CordovaLibApp/www
seems to have some old artifacts that were removed in cordova-iostests/CordovaLibTests/CordovaLibApp/www/tests.js
&tests/cdv-test-project/www
--rule
ignoring options fromeslint:cdvlibtests
&eslint:cdvtestwww
scripts in package.jsonGeneral TODO item(s):
completely disable deprecated Node.js 4 & mark major release(done inmaster
branch)npm outdated
& resolve any outdated depsnpm-check
& resolve any other outdated depsWhat testing has been done on this change?
Test TODO items after some recent updates:
npm test
passes on maccordova run osx
working on new project created bycordova create
and "osx" platform added bycordova platform add https://github.com/brodybits/cordova-osx#cb-update-wip1
cordova-sqlite-storage
test suite withcordova-sqlite-storage
added bycordova plugin add cordova-sqlite-storage
(using Xcode to run)General test TODO item(s):
npm test
items on Travis CIChecklist
Reported an issue in the JIRA databaseCommit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.