Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

[WIP] Major release TODO WIP #49

Closed
wants to merge 6 commits into from
Closed

Conversation

brodycj
Copy link

@brodycj brodycj commented Jun 13, 2018

Platforms affected

macOS ("osx")

What does this PR do?

  • remove node_modules from repo (now done in master branch)
  • drop uncrustify as well as coffee-script & nodeunit from devDependencies (evidently not needed) (now done in master branch)
  • migrate from jasmine-node to jasmine (now done in master branch)
  • upgrade the following dependencies & devDependencies: (now done in master branch)
  • remove bundledDependencies (now done in master branch)
  • explicitly add plist@3 dep (moved to a separate PR)
  • update jasmine & tmp devDeps (now done in master branch)
  • remove outdated tests/.jshintrc (now done in master branch)
  • some eslint updates & fixes, now based on 35fc603 in master branch

eslint TODO item(s):

  • tests/CordovaLibTests/CordovaLibApp/www seems to have some old artifacts that were removed in cordova-ios
  • resolve eslint issues in tests/CordovaLibTests/CordovaLibApp/www/tests.js & tests/cdv-test-project/www
  • remove --rule ignoring options from eslint:cdvlibtests & eslint:cdvtestwww scripts in package.json

General TODO item(s):

  • completely disable deprecated Node.js 4 & mark major release (done in master branch)
  • new major release of cordova-common, using plist@3 and check for any other outdated dependencies
  • upcoming xcode@1.0.1 version (not yet available) with dependency fixes from CB-14145 update dependencies cordova-node-xcode#10
  • check npm outdated & resolve any outdated deps
  • try npm-check & resolve any other outdated deps

What testing has been done on this change?

Test TODO items after some recent updates:

  • npm test passes on mac
  • cordova run osx working on new project created by cordova create and "osx" platform added by cordova platform add https://github.com/brodybits/cordova-osx#cb-update-wip1
  • passes the cordova-sqlite-storage test suite with cordova-sqlite-storage added by cordova plugin add cordova-sqlite-storage (using Xcode to run)

General test TODO item(s):

  • enable test of npm test items on Travis CI

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@brodycj
Copy link
Author

brodycj commented Jun 13, 2018

Outdated coffee-script also removed (tested).

@shazron
Copy link
Member

shazron commented Jun 13, 2018

Sounds good to me -- don't forget the major version update

@brodycj
Copy link
Author

brodycj commented Jun 13, 2018 via email

@brodycj brodycj changed the title Package update WIP FOR DISCUSSION Package update WIP FOR DISCUSSION [MAJOR RELEASE ITEM] Jun 15, 2018
@tripodsan
Copy link
Contributor

+1

@brodycj brodycj changed the title Package update WIP FOR DISCUSSION [MAJOR RELEASE ITEM] [WIP] Package update - MAJOR RELEASE WIP Jul 29, 2018
@brodycj
Copy link
Author

brodycj commented Jul 29, 2018

Recent updates (see description):

  • package*.json remove nodeunit devDep
  • package.json remove bundledDependencies
  • explicitly add plist@3 dep
  • Update jasmine & tmp devDeps

@brodycj brodycj changed the title [WIP] Package update - MAJOR RELEASE WIP [WIP] Major release TODO WIP Aug 13, 2018
erisu added a commit that referenced this pull request Sep 14, 2018
Cherry Picks from (#49)
* package.json drop uncrustify from devDependencies
* package*.json remove coffee-script
* package*.json remove nodeunit devDep
erisu and others added 6 commits September 14, 2018 12:57
Cherry Picks from apacheGH-49 (apache#49)
* package.json drop uncrustify from devDependencies
* package*.json remove coffee-script
* package*.json remove nodeunit devDep
with some eslint rules ignored for now
@brodycj
Copy link
Author

brodycj commented Sep 14, 2018

I just moved the explicit plist@3 dependency update to #66 and rebased the eslint updates on 35fc603 in master branch. (All other changes are now in master branch). Some but not all eslint updates proposed here were incorporated in merged PR #61. Some other TODO items still remain.

@erisu
Copy link
Member

erisu commented Jan 11, 2019

@brodybits If you want to try and finish this PR for release please do.

If there isn't much time, I have a PR (#83) prepared for next release.
If you complete, I should be able to close out mine.

There were some overlapped items but I just ran the same scripts that I run across all other platforms for preparations.

@erisu
Copy link
Member

erisu commented Mar 6, 2019

Closing this PR as the changes are in master and the latest major release.

@erisu erisu closed this Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants