Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

OSX Platform Release Preparation (Cordova 9) #83

Merged
merged 7 commits into from
Jan 17, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 11, 2019

Platforms affected

macOS - OSX

What does this PR do?

This PR contains final preparations for the Cordova 9 release goals.

See Cordova 9 Release Plan.

  • Bumped cordova-common@^3.1.0
  • Bumped ESLint dependencies with correction
    • eslint@^5.12.0
    • eslint-config-semistandard@^13.0.0
    • eslint-config-standard@^12.0.0
    • eslint-plugin-node@^8.0.1
    • eslint-plugin-promise@^4.0.1
    • eslint-plugin-standard@^4.0.0
  • Updated Dependencies
    • nopt@^4.0.1
  • Added bin/lib/** to nyc code coverage
  • Updated Travis to run only npm t that covers ESLint + coverage (testing)

What testing has been done on this change?

  • npm t
    • ESLint
    • Coverage (component & objc testing)
  • Travis CI
  • Platform Add & Prepare
    $ npx cordova@nightly create osxTest com.foobar.osxTest
    $ cd ./osxTest
    $ npx cordova@nightly platform add github:erisu/cordova-osx\#cordova9-prep
    $ npx cordova@nightly run osx
    $ npx cordova@nightly build osx
    

@erisu
Copy link
Member Author

erisu commented Jan 11, 2019

Remaining Task

  • Update Cordova dependency xcode@^2.0.0 once released.

@@ -15,8 +18,7 @@
"cordova:platform"
],
"scripts": {
"cover": "npm run test:coverage",
"test": "npm run eslint && npm run test:component && npm run test:objc",
"test": "npm run eslint && npm run test:coverage",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we intentionally drop the Objective-C test cases here?

Copy link
Member Author

@erisu erisu Jan 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I dropped it intentionally. test:coverage runs this config file.

https://github.com/apache/cordova-osx/blob/01b31dc9a01321ee5aeba781448cb7359b440ca2/tests/spec/coverage.json

It covers both component and objc tests.

"component/**/*[sS]pec.js",
"objc/**/*[sS]pec.js"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, okay

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@erisu erisu merged commit 05fd0fb into apache:master Jan 17, 2019
@erisu erisu mentioned this pull request Jan 18, 2019
2 tasks
@erisu erisu deleted the cordova9-prep branch April 4, 2019 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants