This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
OSX Platform Release Preparation (Cordova 9) #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- nopt@^4.0.1 - underscore@^1.9.1
- cordova-common@^3.1.0 - xcode@^1.1.0
Remaining Task
|
This was referenced Jan 11, 2019
dpogue
reviewed
Jan 16, 2019
@@ -15,8 +18,7 @@ | |||
"cordova:platform" | |||
], | |||
"scripts": { | |||
"cover": "npm run test:coverage", | |||
"test": "npm run eslint && npm run test:component && npm run test:objc", | |||
"test": "npm run eslint && npm run test:coverage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we intentionally drop the Objective-C test cases here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I dropped it intentionally. test:coverage
runs this config file.
It covers both component and objc tests.
"component/**/*[sS]pec.js",
"objc/**/*[sS]pec.js"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, okay
dpogue
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
macOS - OSX
What does this PR do?
This PR contains final preparations for the Cordova 9 release goals.
See Cordova 9 Release Plan.
cordova-common@^3.1.0
nopt@^4.0.1
bin/lib/**
to nyc code coveragenpm t
that covers ESLint + coverage (testing)What testing has been done on this change?
npm t