Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA_URL is improperly prefixed #420

Closed
0awful opened this issue Jan 31, 2019 · 12 comments · Fixed by #910
Closed

DATA_URL is improperly prefixed #420

0awful opened this issue Jan 31, 2019 · 12 comments · Fixed by #910

Comments

@0awful
Copy link

0awful commented Jan 31, 2019

Getting a dataURL from the cordova-plugin-camera omits the 'data:'mimeType';base64, '

hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Feb 24, 2019
@hazems
Copy link
Member

hazems commented Feb 24, 2019

This is currently the actual API behavior across all platforms. I do not think it is a bug since it is consistent across all platforms.

@jcesarmobile
Copy link
Member

It's a known issue https://issues.apache.org/jira/browse/CB-9819

@hazems
Copy link
Member

hazems commented Feb 26, 2019

@jcesarmobile If we agree to have this supported across platforms, here is my Android support proposal:
hazems@e6609c0

@jcesarmobile
Copy link
Member

I personally agree, but for this kind of changes is recommended to send a mail to the dev list proposing it

@hazems
Copy link
Member

hazems commented Feb 27, 2019

Sure will share it with the group.

@hazems
Copy link
Member

hazems commented Feb 27, 2019

Sent to development group email.

hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 3, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 3, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 3, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 3, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 8, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 8, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 8, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 8, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Mar 17, 2019
@hazems
Copy link
Member

hazems commented Mar 17, 2019

@imizaac A PR is created to fix this behavior across of all Camera platforms:
#432

cc @jcesarmobile

@hazems
Copy link
Member

hazems commented Apr 7, 2019

If anyone or @imizaac is interested in this fix, feel free to thumb up this PR which fixes this issue across all of Cordova supported platforms:
#432

Thanks

@ruisilva450
Copy link

Any timeframe for this to get merged?

@janpio
Copy link
Member

janpio commented May 8, 2019

No.

hazems added a commit to hazems/cordova-plugin-camera that referenced this issue May 9, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue May 9, 2019
@hazems
Copy link
Member

hazems commented May 9, 2019

@ruisilva450 This is the PR that fix this issue across all platforms:
#432

Please thumbs it up to show an interest in merging it.

@ruisilva450
Copy link

@ruisilva450 This is the PR that fix this issue across all platforms:
#432

Please thumbs it up to show an interest in merging it.

I already saw that, has my thumbs up and that's why I'm asking 😃

hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Jun 30, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Jun 30, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Jun 30, 2019
hazems added a commit to hazems/cordova-plugin-camera that referenced this issue Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants