Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Return data uris as an URI #910

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Makes data urls returned as actual URIs instead of just the base 64 encoded data.
This sisters PR #902

Closes #420

Description

Prefixes the base64 with the data uri header.

Testing

paramedic tests passes
Manual testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 8.0.0 milestone Oct 26, 2024
@breautek breautek requested a review from erisu October 26, 2024 00:54
src/android/CameraLauncher.java Outdated Show resolved Hide resolved
@breautek breautek merged commit a672c31 into apache:master Oct 26, 2024
14 of 15 checks passed
@breautek breautek deleted the fix/data-uri branch October 26, 2024 03:58
@jcesarmobile
Copy link
Member

Doesn’t really fully closes #420, this only changes the behavior for android, but iOS and browser are still “broken”

@breautek
Copy link
Contributor Author

Yah, it will be covered by #911 and #912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA_URL is improperly prefixed
3 participants