Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for using the saveToPhotoAlbum option on iOS 11 #294

Closed
wants to merge 1 commit into from

Conversation

joseph-perez
Copy link

@joseph-perez joseph-perez commented Oct 20, 2017

iOS 11 added a new permission when trying to get write only access to
the photo library.

Platforms affected

iOS 11

What does this PR do?

Fixes the crash that occurs when trying to use the saveToPhotoAlbum option.

What testing has been done on this change?

I tested my change on a iphone 7 running iOS 11.

Checklist

  • CB-13477 in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

iOS 11 added a new permission when trying to get write only access to
the photo library.
@joseph-perez joseph-perez changed the title fix for using the saveToPhotoAlbum option fix for using the saveToPhotoAlbum option on iOS 11 Oct 20, 2017
@jcesarmobile
Copy link
Member

Thanks for the PR, but we are removing the variables from the plugins as they conflict with others.
The right way of setting the Usage Descriptions is edit-config tag.
See #295

Can you close the PR?

@joseph-perez
Copy link
Author

Yeah sure thing! Sorry about that

@jcesarmobile
Copy link
Member

no problems, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants