Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13264 (iOS): Remove ios usage descriptions #295

Closed
wants to merge 1 commit into from

Conversation

jcesarmobile
Copy link
Member

Platforms affected

iOS

What does this PR do?

Removes the usage description variables and document how to set them using edit-config tab

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@kleeb
Copy link

kleeb commented Jan 19, 2018

its not working in Phonegap Build

@jcesarmobile
Copy link
Member Author

This just removes the usage description variables from the plugin.xml, so not sure how this "is not working in Phonegap build".

Anyway, this is not the place to report your Phonegap build problems

@kleeb
Copy link

kleeb commented Jan 19, 2018

thats true, but there is no way to add those params to the plist file with the latest update of PGB
which more or less makes the cordova-plugin-camera version stuck at 2.4.1...

unless using cordova-plugin-ios-camera-permissions

@jcesarmobile
Copy link
Member Author

Yes, there is a way, you have to use edit-config tag as documented in the README.md

@kleeb
Copy link

kleeb commented Jan 19, 2018

edit-config doesn't work in the Phonegap Build version cli-7.1.0

@kleeb
Copy link

kleeb commented Jan 19, 2018

just stating that thousands of PGB users will soon have problem building native iOS when they update this plugin

however this may have a good impact, as they may think of switching to PWA ;-)

@jcesarmobile
Copy link
Member Author

edit-config used to work in PGB. If it's now broken in cli-7.1.0 report it to Adobe, this plugin is from Apache.

@jcesarmobile
Copy link
Member Author

@kleeb FYI, I've created a sample app and built it in PGB setting the cli-7.1.0 and the texts were set correctly. You can try it yourself https://github.com/jcesarmobile/cordova-plugin-camera-sample.

First time I built it without version and was built with 6.5.0 and didn't include the texts but then I changed the CLI version, built it again and worked fine.

@kleeb
Copy link

kleeb commented Jan 22, 2018

Thanks @jcesarmobile
For this repo it works like charm

For my project it doesn't, some other plugin must be removing them.

@kleeb
Copy link

kleeb commented Jan 22, 2018

Ok, we are using the old builder, and then it is not working

<preference name='pgb-builder-version' value='1' />

@jcesarmobile
Copy link
Member Author

If you want to use the old builder then you will need to use older versions of the plugins.
Anyway, if you have doubts or problems with Phonegap Build you should go to their forums https://forums.adobe.com/community/phonegap/build

@kleeb
Copy link

kleeb commented Jan 22, 2018

I don't agree with that. This is just the different way how PGB is building the native package.
I don't see any connection with the plugin versions.

@jcesarmobile
Copy link
Member Author

To use latest version of the plugins you need to use edit-config tag, period.

If Phonegap Build old builder doesn't allow to use edit-config tag you have a few options:

  1. Use the new builder.
  2. Use an older version of the plugin where edit-config tag is not need.
  3. Use another plugin that writes the usage descriptions.

Anyway, I have told you a few times that this plugins belongs to Apache and Phonegap Build belongs to Adobe, they have to adapt to our changes, not the other way around. And in this case they already provide a way, so it's you who has to switch to that or find a workaround.

Please, stop commenting here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants