-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-13264 (iOS): Remove ios usage descriptions #295
Conversation
415c335
to
33695a9
Compare
33695a9
to
9e669dc
Compare
its not working in Phonegap Build |
This just removes the usage description variables from the plugin.xml, so not sure how this "is not working in Phonegap build". Anyway, this is not the place to report your Phonegap build problems |
thats true, but there is no way to add those params to the plist file with the latest update of PGB unless using cordova-plugin-ios-camera-permissions |
Yes, there is a way, you have to use |
edit-config doesn't work in the Phonegap Build version cli-7.1.0 |
just stating that thousands of PGB users will soon have problem building native iOS when they update this plugin however this may have a good impact, as they may think of switching to PWA ;-) |
edit-config used to work in PGB. If it's now broken in cli-7.1.0 report it to Adobe, this plugin is from Apache. |
@kleeb FYI, I've created a sample app and built it in PGB setting the cli-7.1.0 and the texts were set correctly. You can try it yourself https://github.com/jcesarmobile/cordova-plugin-camera-sample. First time I built it without version and was built with 6.5.0 and didn't include the texts but then I changed the CLI version, built it again and worked fine. |
Thanks @jcesarmobile For my project it doesn't, some other plugin must be removing them. |
Ok, we are using the old builder, and then it is not working
|
If you want to use the old builder then you will need to use older versions of the plugins. |
I don't agree with that. This is just the different way how PGB is building the native package. |
To use latest version of the plugins you need to use If Phonegap Build old builder doesn't allow to use
Anyway, I have told you a few times that this plugins belongs to Apache and Phonegap Build belongs to Adobe, they have to adapt to our changes, not the other way around. And in this case they already provide a way, so it's you who has to switch to that or find a workaround. Please, stop commenting here. |
Platforms affected
iOS
What does this PR do?
Removes the usage description variables and document how to set them using edit-config tab
What testing has been done on this change?
Checklist