Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent audio recording from getting stuck #152

Conversation

neno-giscloud
Copy link

Swiping away the recording modal on iOS 13 causes the plugin

  • to never stop in the background
  • never to call any callback
  • to prevent you from starting another recording

This commit disables the swiping action.

Platforms affected

iOS

Motivation and Context

This is a temporary fix to avoid #151

Description

Using the isModalInPresentation prop of the UIViewController, I've disable the swiping action.

Testing

This has only been tested on an iOS 13 iPhone 6S. The test was to try and dismiss the recording modal with a swipe. The recording modal was opened by running

navigator.device.capture.captureAudio();

in a javascript console.

Checklist

  • I've run the tests to see all new and existing tests pass
  • [] I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Swiping away the recording modal on iOS 13 causes the plugin

* to never stop in the background
* never to call any callback
* to prevent you from starting another recording

This commit disables the swiping action.
@Pazkov
Copy link

Pazkov commented Feb 25, 2020

Hi,
when you plan to merge in master?

Thanks

@StevenConradEllis
Copy link

Hi,
To echo @Pazkov it would be great to get this merged into master at some point.

@leosbrf
Copy link

leosbrf commented Jun 8, 2020

I agree with @Pazkov and @StevenConradEllis .

@fess-v
Copy link

fess-v commented Mar 7, 2021

Hi! It is a real problem, march 2021 still not merged, please do it

@ath0mas
Copy link
Contributor

ath0mas commented Mar 11, 2021

Audio modal dismissing is also fixed through PR #186 : better than this one described as a temporary fix?

@erisu
Copy link
Member

erisu commented Aug 9, 2023

Resolved by #278 which is a rebase of #186

@erisu erisu closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants