Prevent audio recording from getting stuck #152
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swiping away the recording modal on iOS 13 causes the plugin
This commit disables the swiping action.
Platforms affected
iOS
Motivation and Context
This is a temporary fix to avoid #151
Description
Using the
isModalInPresentation
prop of the UIViewController, I've disable the swiping action.Testing
This has only been tested on an iOS 13 iPhone 6S. The test was to try and dismiss the recording modal with a swipe. The recording modal was opened by running
in a javascript console.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)