Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): CAPTURE_APPLICATION_BUSY error when dismissing modal by swipe #186

Conversation

BardRedStar
Copy link
Contributor

@BardRedStar BardRedStar commented Jul 31, 2020

Fix a bug with modal presentation style controller dismissing on iOS 13 and above. For now, only for audio capture controller.

Platforms affected

iOS 13 and above.

Motivation and Context

Apple added new feature for modals on iOS 13, they might be dismissed by swipe. Such behavior was not handled, so controller threw CAPTURE_APPLICATION_BUSY, on opening new modal.

closes #152
fixes #151

Description

I added audio capture controller as adaptive controller delegate for itself and implemented the method to handle dismiss event. Then I dismiss the controller correctly, as by tap on the “Done” button.

Testing

I didn’t find any tests for this plugin.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

… iOS 13 and above. For now, only for audio capture controller.
@ath0mas
Copy link
Contributor

ath0mas commented Mar 12, 2021

Fix #151

@erisu erisu changed the title iOS: Fix bug with modal presentation style controller dismissing on iOS 13 and above fix(ios): CAPTURE_APPLICATION_BUSY error when dismissing modal by swipe Aug 7, 2023
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Also tested in a sample project and confirmed fix.

@erisu
Copy link
Member

erisu commented Aug 7, 2023

@BardRedStar Do you think you can rebase and resolve the conflicts?

I will merge it in as soon as its resolved.

@ath0mas
Copy link
Contributor

ath0mas commented Aug 7, 2023

I can help on this rebase if it has to be done quickly this week ; tell me @BardRedStar @erisu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 13 Audio Recording Modal Swipe Dismiss
3 participants