pkg fixup #17
Merged
pkg fixup #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raphinesse
commented
Oct 3, 2020
raphinesse
commented
- chore(pkg): remove field "maintainers"
- fix(pkg): fix declaration for binary "create"
erisu
reviewed
Oct 3, 2020
| @@ -18,17 +20,6 @@ | |||
| "author": "Apache Software Foundation", | |||
| "license": "Apache-2.0", | |||
| "bugs": "https://github.com/apache/cordova-test-platform/issues", | |||
| "homepage": "https://github.com/cordova/cordova-test-platform#readme", | |||
There was a problem hiding this comment.
Is this meant to be removed? Description did not mention it.
There was a problem hiding this comment.
Looks like you are removing it instead from everywhere. So I approved it.
Thought it might have been better to point to the actual home page so people coming from npmjs has a quick link to our home page.
There was a problem hiding this comment.
I removed it since only four packages had this field set at all. Two of them to the default value
erisu
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.