Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg fixup #17

Merged
merged 3 commits into from
Oct 4, 2020
Merged

pkg fixup #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0e5c80
chore(pkg): remove field "maintainers"
raphinesse Oct 3, 2020
eea7237
fix(pkg): fix declaration for binary "create"
raphinesse Oct 3, 2020
3c2be8b
chore(pkg): remove default-valued field "homepage"
raphinesse Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
"name": "cordova-test-platform",
"version": "0.0.5",
"description": "Platform that simply stubs the platformAPI for testing and education",
"create": "src/bin/create",
"bin": {
"create": "src/bin/create"
},
"main": "src/cordova/Api.js",
"scripts": {
"cover": "istanbul cover --root bin/templates/cordova --print detail jasmine",
Expand All @@ -18,17 +20,6 @@
"author": "Apache Software Foundation",
"license": "Apache-2.0",
"bugs": "https://github.com/apache/cordova-test-platform/issues",
"homepage": "https://github.com/cordova/cordova-test-platform#readme",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be removed? Description did not mention it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are removing it instead from everywhere. So I approved it.

Thought it might have been better to point to the actual home page so people coming from npmjs has a quick link to our home page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it since only four packages had this field set at all. Two of them to the default value

"maintainers": [
{
"name": "stevegill",
"email": "stevengill97@gmail.com"
},
{
"name": "Jesse MacFadyen",
"email": "purplecabbage@apache.org"
}
],
"dependencies": {
"cordova-common": "^3.0.0",
"nopt": "^4.0.1",
Expand Down