chore: check missingInput for Comet plan nodes#2795
Merged
comphead merged 5 commits intoapache:mainfrom Nov 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
============================================
+ Coverage 56.12% 58.27% +2.14%
- Complexity 976 1423 +447
============================================
Files 119 157 +38
Lines 11743 14124 +2381
Branches 2251 2365 +114
============================================
+ Hits 6591 8231 +1640
- Misses 4012 4702 +690
- Partials 1140 1191 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
|
comphead
changed the title
missingInput for Comet plan nodesmissingInput for Comet plan nodes
wForget
reviewed
Nov 18, 2025
martin-g
approved these changes
Nov 18, 2025
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
wForget
approved these changes
Nov 19, 2025
Contributor
Author
mbutrovich
added a commit
to mbutrovich/datafusion-comet
that referenced
this pull request
Nov 19, 2025
mbutrovich
added a commit
that referenced
this pull request
Nov 19, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
* chore: check `missingInput` for Comet plan nodes --------- Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2794 #2796.
Rationale for this change
What changes are included in this PR?
Added an assertion to check Comet plan nodes with with missingOutput, also fixed CometTakeOrderedAndProjectExec
How are these changes tested?