Skip to content

Comments

chore: Update q79 golden plan for Spark 4.0 after #2795#2800

Merged
mbutrovich merged 1 commit intoapache:mainfrom
mbutrovich:q79_spark4
Nov 19, 2025
Merged

chore: Update q79 golden plan for Spark 4.0 after #2795#2800
mbutrovich merged 1 commit intoapache:mainfrom
mbutrovich:q79_spark4

Conversation

@mbutrovich
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

PRs are failing CI for q79 in Spark 4.0 after merging #2795.

What changes are included in this PR?

New plan generated on main branch with:

JAVA_HOME=`/usr/libexec/java_home -v 17`
make clean; make release PROFILES="-Pspark-4.0"
SPARK_GENERATE_GOLDEN_FILES=1 ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV1_4_PlanStabilitySuite" -Pspark-4.0 -nsu test
SPARK_GENERATE_GOLDEN_FILES=1  ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV2_7_PlanStabilitySuite" -Pspark-4.0 -nsu test

How are these changes tested?

CI

@mbutrovich mbutrovich requested a review from comphead November 19, 2025 17:52
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.30%. Comparing base (f09f8af) to head (f136e9f).
⚠️ Report is 712 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2800      +/-   ##
============================================
+ Coverage     56.12%   58.30%   +2.17%     
- Complexity      976     1423     +447     
============================================
  Files           119      162      +43     
  Lines         11743    14143    +2400     
  Branches       2251     2362     +111     
============================================
+ Hits           6591     8246    +1655     
- Misses         4012     4704     +692     
- Partials       1140     1193      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbutrovich wondering how #2795 passed 🤔

@mbutrovich
Copy link
Contributor Author

Thanks @mbutrovich wondering how #2795 passed 🤔

I was trying to figure out the same thing. I never came to a good conclusion.

@mbutrovich mbutrovich merged commit 695c003 into apache:main Nov 19, 2025
104 checks passed
@mbutrovich mbutrovich deleted the q79_spark4 branch November 19, 2025 19:14
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants