Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Comet columnar shuffle should not be on top of another Comet shuffle operator #296

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Apr 21, 2024

Which issue does this PR close?

Closes #295.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Member Author

viirya commented Apr 21, 2024

cc @sunchao @andygrove

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @viirya

@viirya viirya merged commit f4d3869 into apache:main Apr 21, 2024
28 checks passed
@viirya
Copy link
Member Author

viirya commented Apr 21, 2024

Merged. Thanks.

@viirya viirya deleted the fix_repeated_shuffle branch April 21, 2024 17:10
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
…ffle operator (apache#296)

* fix: Comet columnar shuffle should not be on top of another Comet shuffle operator

* Fix 3.2 build
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
* Don't trigger chain 3.2_*, 3.3_*, or 3.4_2.12 pipelines

* Run TPC-DS and TPC-H using 3.4_2.13

* Disable all remaining 3.4_2.12 pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated shuffle should not trigger Comet columnar shuffle
2 participants