Skip to content

feat: enable native_datafusion in auto scan mode [WIP] [IGNORE]#3307

Closed
andygrove wants to merge 4 commits intoapache:mainfrom
andygrove:enable-native-df-auto
Closed

feat: enable native_datafusion in auto scan mode [WIP] [IGNORE]#3307
andygrove wants to merge 4 commits intoapache:mainfrom
andygrove:enable-native-df-auto

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Jan 28, 2026

Which issue does this PR close?

Closes #.

Rationale for this change

  • I want to see how many failures happen

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.14%. Comparing base (f09f8af) to head (7527fa7).
⚠️ Report is 905 commits behind head on main.

Files with missing lines Patch % Lines
.../apache/comet/serde/operator/CometNativeScan.scala 25.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3307      +/-   ##
============================================
- Coverage     56.12%   55.14%   -0.98%     
- Complexity      976     1340     +364     
============================================
  Files           119      175      +56     
  Lines         11743    16176    +4433     
  Branches       2251     2686     +435     
============================================
+ Hits           6591     8921    +2330     
- Misses         4012     5990    +1978     
- Partials       1140     1265     +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…pache#3309)

With native_datafusion enabled in auto scan mode, test helpers that
check for specific scan config values fail because auto resolves at
plan time, not config time. Invert the logic so tests check for the
legacy native_comet mode instead, which is forward-compatible with
auto and any future scan implementations.

- Rename usingDataSourceExec → usingLegacyNativeCometScan (inverted)
- Rename usingDataSourceExecWithIncompatTypes → hasUnsignedSmallIntSafetyCheck
- Update all call sites across 11 test files

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@andygrove andygrove changed the title feat: enable native_datafusion in auto scan mode [WIP] feat: enable native_datafusion in auto scan mode [WIP] [IGNORE] Jan 29, 2026
Add checks for metadata columns, Parquet field ID reads, bucketed scans,
and row index generation so that auto mode falls back to native_iceberg_compat.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@andygrove
Copy link
Member Author

I filed issues for all failures, so will close this PR now.

@andygrove andygrove closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments