docs: Add contributor guide page for SQL file tests#3333
Merged
andygrove merged 4 commits intoapache:mainfrom Jan 31, 2026
Merged
docs: Add contributor guide page for SQL file tests#3333andygrove merged 4 commits intoapache:mainfrom
andygrove merged 4 commits intoapache:mainfrom
Conversation
Document the CometSqlFileTestSuite test framework including file format, directives (Config, ConfigMatrix, MinSparkVersion), query assertion modes, how to add new tests, and how to handle failures. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
changed the title
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add guidance on covering all combinations of literal and column arguments, edge cases, and using agentic coding tools. Move SQL file tests section higher in the development guide as the recommended approach for expression testing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mbutrovich
approved these changes
Jan 31, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds documentation for the new testing approach in #3328.
I am creating this separate PR for the docs so that we do not have to run all of the tests every time we change the docs.
CometSqlFileTestSuite.sqlfile format, all directives (Config,ConfigMatrix,MinSparkVersion), all query assertion modes, how to add new tests, and how to handle failures🤖 Generated with Claude Code