feat: pass vended credentials to Iceberg native scan#3523
Merged
mbutrovich merged 4 commits intoapache:mainfrom Feb 16, 2026
Merged
feat: pass vended credentials to Iceberg native scan#3523mbutrovich merged 4 commits intoapache:mainfrom
mbutrovich merged 4 commits intoapache:mainfrom
Conversation
Contributor
|
Thank you for the PR @tokoko! I'm thrilled that others are trying to improve the native Iceberg integration. I will take a look today. |
mbutrovich
requested changes
Feb 16, 2026
Contributor
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks again @tokoko. This looks really close! I have a few small suggestions.
spark/src/main/scala/org/apache/comet/iceberg/IcebergReflection.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala
Outdated
Show resolved
Hide resolved
mbutrovich
approved these changes
Feb 16, 2026
Contributor
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks for the great improvement, @tokoko! Approved pending CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3522.
What changes are included in this PR?
SupportsStorageCredentialsinterface in latest iceberg which should eventually make reflection code less ugly, but we can't use it yet.RestCatalogAdaptertest utility to enable fake credential vending for testing.How are these changes tested?
RestCatalogAdapterthat injects minio credentials into LoadTable response objects.