adding expr to string for IsNotNull IsTrue IsFalse and IsUnkown (#9739)

* adding expr to string for IsNotNull IsTrue IsFalse and IsUnkown * fix clippy * change to raw string
apache · Mar 23, 2024 · 1dbec3e · 1dbec3e
1 parent 6c63051
commit 1dbec3e
Showing 1 changed file with 25 additions and 0 deletions.
diff --git a/datafusion/sql/src/unparser/expr.rs b/datafusion/sql/src/unparser/expr.rs
@@ -181,6 +181,18 @@ impl Unparser<'_> {
                     negated: insubq.negated,
                 })
             }
+            Expr::IsNotNull(expr) => {
+                Ok(ast::Expr::IsNotNull(Box::new(self.expr_to_sql(expr)?)))
+            }
+            Expr::IsTrue(expr) => {
+                Ok(ast::Expr::IsTrue(Box::new(self.expr_to_sql(expr)?)))
+            }
+            Expr::IsFalse(expr) => {
+                Ok(ast::Expr::IsFalse(Box::new(self.expr_to_sql(expr)?)))
+            }
+            Expr::IsUnknown(expr) => {
+                Ok(ast::Expr::IsUnknown(Box::new(self.expr_to_sql(expr)?)))
+            }
             _ => not_impl_err!("Unsupported expression: {expr:?}"),
         }
     }
@@ -599,6 +611,19 @@ mod tests {
                 }),
                 "COUNT(DISTINCT *)",
             ),
+            (Expr::IsNotNull(Box::new(col("a"))), r#""a" IS NOT NULL"#),
+            (
+                Expr::IsTrue(Box::new((col("a") + col("b")).gt(lit(4)))),
+                r#"(("a" + "b") > 4) IS TRUE"#,
+            ),
+            (
+                Expr::IsFalse(Box::new((col("a") + col("b")).gt(lit(4)))),
+                r#"(("a" + "b") > 4) IS FALSE"#,
+            ),
+            (
+                Expr::IsUnknown(Box::new((col("a") + col("b")).gt(lit(4)))),
+                r#"(("a" + "b") > 4) IS UNKNOWN"#,
+            ),
         ];
 
         for (expr, expected) in tests {