adding expr to string for IsNotNull IsTrue IsFalse and IsUnkown #9739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyy1000
reviewed
Mar 22, 2024
datafusion/sql/src/unparser/expr.rs
Outdated
| (Expr::IsNotNull(Box::new(col("a"))), "\"a\" IS NOT NULL"), | ||
| ( | ||
| Expr::IsTrue(Box::new((col("a") + col("b")).gt(lit(4)))), | ||
| "((\"a\" + \"b\") > 4) IS TRUE", |
There was a problem hiding this comment.
What about using raw strings? https://doc.rust-lang.org/reference/tokens.html#raw-string-literals
It matches the other tests. :)
7 tasks
alamb
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
This code looks good to me -- thank you @Lordworms
I think it would be great to implement @yyy1000 's suggestion https://github.com/apache/arrow-datafusion/pull/9739/files#r1535890652 and then we can merge it.
alamb
approved these changes
Mar 23, 2024
| (Expr::IsNotNull(Box::new(col("a"))), r#""a" IS NOT NULL"#), | ||
| ( | ||
| Expr::IsTrue(Box::new((col("a") + col("b")).gt(lit(4)))), | ||
| r#"(("a" + "b") > 4) IS TRUE"#, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9731
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?