move field_util from physical-expr to expr (#2250)

apache · Apr 17, 2022 · e0334de · e0334de
1 parent 441cf09
commit e0334de
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/datafusion/core/src/logical_plan/expr_schema.rs b/datafusion/core/src/logical_plan/expr_schema.rs
@@ -22,7 +22,7 @@ use crate::physical_plan::{
 use arrow::compute::can_cast_types;
 use arrow::datatypes::DataType;
 use datafusion_common::{DFField, DFSchema, DataFusionError, ExprSchema, Result};
-use datafusion_physical_expr::field_util::get_indexed_field;
+use datafusion_expr::field_util::get_indexed_field;
 
 /// trait to allow expr to typable with respect to a schema
 pub trait ExprSchemable {

diff --git a/datafusion/physical-expr/src/field_util.rs → datafusion/expr/src/field_util.rs b/datafusion/physical-expr/src/field_util.rs → datafusion/expr/src/field_util.rs
@@ -18,8 +18,7 @@
 //! Utility functions for complex field access
 
 use arrow::datatypes::{DataType, Field};
-use datafusion_common::ScalarValue;
-use datafusion_common::{DataFusionError, Result};
+use datafusion_common::{DataFusionError, Result, ScalarValue};
 
 /// Returns the field access indexed by `key` from a [`DataType::List`] or [`DataType::Struct`]
 /// # Error

diff --git a/datafusion/expr/src/lib.rs b/datafusion/expr/src/lib.rs
@@ -21,6 +21,7 @@ mod built_in_function;
 mod columnar_value;
 pub mod expr;
 pub mod expr_fn;
+pub mod field_util;
 mod function;
 mod literal;
 mod operator;

diff --git a/datafusion/physical-expr/src/expressions/get_indexed_field.rs b/datafusion/physical-expr/src/expressions/get_indexed_field.rs
@@ -17,7 +17,7 @@
 
 //! get field of a `ListArray`
 
-use crate::{field_util::get_indexed_field as get_data_type_field, PhysicalExpr};
+use crate::PhysicalExpr;
 use arrow::array::Array;
 use arrow::array::{ListArray, StructArray};
 use arrow::compute::concat;
@@ -28,7 +28,9 @@ use arrow::{
 use datafusion_common::DataFusionError;
 use datafusion_common::Result;
 use datafusion_common::ScalarValue;
-use datafusion_expr::ColumnarValue;
+use datafusion_expr::{
+    field_util::get_indexed_field as get_data_type_field, ColumnarValue,
+};
 use std::convert::TryInto;
 use std::fmt::Debug;
 use std::{any::Any, sync::Arc};

diff --git a/datafusion/physical-expr/src/lib.rs b/datafusion/physical-expr/src/lib.rs
@@ -23,7 +23,6 @@ pub mod conditional_expressions;
 pub mod crypto_expressions;
 pub mod datetime_expressions;
 pub mod expressions;
-pub mod field_util;
 mod functions;
 mod hyperloglog;
 pub mod math_expressions;