Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: move field_util from physical-expr crate to expr crate #2250

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Apr 16, 2022

Which issue does this PR close?

Related to #2247

Rationale for this change

field_utils does not refer to physical expressions so there is no need for it to be in the physical-expr crate. Moving this to the expr crate removes one LogicalPlan dependency on the physical-expr crate.

What changes are included in this PR?

Move field_utils.rs from physical-expr crate to expr crate.

Are there any user-facing changes?

No

@andygrove andygrove changed the title minor: move field_util from physical-expr cratre to expr crate minor: move field_util from physical-expr crate to expr crate Apr 16, 2022
@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Apr 16, 2022
Copy link
Contributor

@jychen7 jychen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
Copy link
Member Author

AMD64 tests failed due to No space left on device so not related to changes in this PR

@xudong963 xudong963 merged commit e0334de into apache:master Apr 17, 2022
@andygrove andygrove deleted the move-field-util branch January 27, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants