-
Notifications
You must be signed in to change notification settings - Fork 2k
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem or challenge?
Currently, datafusion.runtime.max_temp_directory_size is a disk based config but when it is set as invalid limit or invalid unit, memory limit is being mentioned in error message. This seems to introduce inconsistency between disk vs memory limit. This error message can be updated more generic by setting config name and covering both memory and disk based capacity/size settings.
Current:
statement error DataFusion error: Error during planning: Failed to parse number from memory limit 'invalid_size'
SET datafusion.runtime.max_temp_directory_size = 'invalid_size'
statement error DataFusion error: Error during planning: Unsupported unit 'B' in memory limit '1024B'
SET datafusion.runtime.max_temp_directory_size = '1024B'
New:
statement error DataFusion error: Error during planning: Failed to parse number from 'datafusion.runtime.max_temp_directory_size', limit 'invalid_size'
SET datafusion.runtime.max_temp_directory_size = 'invalid_size'
statement error DataFusion error: Error during planning: Unsupported unit 'B' in 'datafusion.runtime.max_temp_directory_size', limit '1024B'. Unit must be one of: 'K', 'M', 'G'
SET datafusion.runtime.max_temp_directory_size = '1024B'
Describe the solution you'd like
Following improvements can be applied:
- Setting problematic config name in error message to cover all use-cases (e.g: both memory and disk based capacity/size settings),
- Allowed units are also added in error message,
SessionContext.parse_memory_limit()=>SessionContext.parse_capacity_limit()function signature is also being renamed to cover both memory and disk based capacity/size settings. This is applied to bothSessionContextandBenchmark Utils,- Being added new UT cases to cover these negative use-cases in terms of above changes.
Describe alternatives you've considered
No response
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request