fix: Provide more generic API for the capacity limit parsing#20372
Open
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Open
fix: Provide more generic API for the capacity limit parsing#20372erenavsarogullari wants to merge 1 commit intoapache:mainfrom
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Conversation
996a2e7 to
99aa536
Compare
This was referenced Feb 15, 2026
99aa536 to
f2dab71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Currently,
datafusion.runtime.max_temp_directory_sizeis a disk based config but when it is set asinvalid limitorinvalid unit,memory limitis mentioned in error message. This seems to introduceinconsistencybetween related runtime config and error message likediskvsmemorylimit. This error message can be updated more generic by setting problematic config name and covering both memory and disk based capacity/size settings.Current:
New:
What changes are included in this PR?
Following improvements are being offered:
SessionContext.parse_memory_limit()=>SessionContext.parse_capacity_limit()function signature is also being renamed to cover both memory and disk based capacity/size settings. This is applied to bothSessionContextandBenchmark Utils,Are these changes tested?
Yes and adding new UT cases
Are there any user-facing changes?
Yes, new more detailed and generic error messages are exposed to end-users.