fix: use return_type_from_args and mark nullable if any of the input is nullable
#14841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
commented
Feb 23, 2025
This reverts commit b1b7aac.
alamb
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Currently because this function does not override
return_type_from_args, it will return that the return type is always nullable however this is not true, as it is only nullable if any of the argument is nullableWhat changes are included in this PR?
Implement
return_type_from_argsto return nullable true if any of the input is nullableAre these changes tested?
yes
Are there any user-facing changes?
yes, we will now be able to get if the result is actually nullable or not.
The type has changed, and calls to data_type will return error if that count as a breaking change