Skip to content

Conversation

rluvaton
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

Needed for so I can return internal_err in:

#14841 (comment)

What changes are included in this PR?

Changed test_function macro to use return_type_from_args and not return_type

Are these changes tested?

existing tests

Are there any user-facing changes?

Nope

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the tests are all possible to move to sqllogictest and some of them are already covered, maybe we could remove them

@alamb
Copy link
Contributor

alamb commented Feb 25, 2025

It seems like the tests are all possible to move to sqllogictest and some of them are already covered, maybe we could remove them

this would be a great follow on issue -- I think it basically means removing the test_function macro and port all the tests to .slt

@alamb alamb merged commit d0ab003 into apache:main Feb 25, 2025
24 checks passed
@alamb
Copy link
Contributor

alamb commented Feb 25, 2025

Thanks @rluvaton and @jayzhan211

@rluvaton rluvaton deleted the change-test-function-to-use-return-type-from-args branch March 3, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants