Implement tree explain for LocalLimitExec
#15232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Mar 14, 2025
|
|
||
| query TT | ||
| explain VERBOSE | ||
| SELECT /*+ REPARTITION(4) */ * |
There was a problem hiding this comment.
do we need this hint here?
There was a problem hiding this comment.
yes, that was not necessary here, removed it
alamb
reviewed
Mar 14, 2025
| 12)└───────────────────────────┘ | ||
|
|
||
| query TT | ||
| explain VERBOSE SELECT * FROM limit_table LIMIT 10; |
There was a problem hiding this comment.
why does this use EXPLAIN VERBOSE? All the rest of the queries in this file just use EXPLAIN 🤔
I think it would be better to do the same
Suggested change
| explain VERBOSE SELECT * FROM limit_table LIMIT 10; | |
| explain SELECT * FROM limit_table LIMIT 10; |
There was a problem hiding this comment.
I took the liberty of making this change and pushing to the branch
alamb
approved these changes
Mar 14, 2025
|
Thanks again @shruti2522 and @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
treeexplain forLocalLimitExec#15025 .Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?