Skip to content

Implement tree explain for LocalLimitExec #15232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025
Merged

Implement tree explain for LocalLimitExec #15232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0072eac
feat: implement tree explain for locallimitexec
shruti2522 Mar 14, 2025
17fb753
remove hint
shruti2522 Mar 14, 2025
3d375f0
Do not use VERBOSE
alamb Mar 14, 2025
56669d4
Merge remote-tracking branch 'apache/main' into local-limit-exec
alamb Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions datafusion/physical-plan/src/limit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,7 @@ impl DisplayAs for LocalLimitExec {
write!(f, "LocalLimitExec: fetch={}", self.fetch)
}
DisplayFormatType::TreeRender => {
// TODO: collect info
write!(f, "")
write!(f, "limit={}", self.fetch)
}
}
}
Expand Down
20 changes: 20 additions & 0 deletions datafusion/sqllogictest/test_files/explain_tree.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ AS SELECT
FROM
hashjoin_datatype_table_t2_source

statement ok
CREATE TABLE limit_table AS
SELECT * FROM table1
UNION ALL SELECT * FROM table1

######## Begin Queries ########

# Filter
Expand Down Expand Up @@ -246,6 +251,21 @@ physical_plan
11)│ format: csv │
12)└───────────────────────────┘

query TT
explain SELECT * FROM limit_table LIMIT 10;
----
physical_plan
01)┌───────────────────────────┐
02)│ CoalescePartitionsExec │
03)└─────────────┬─────────────┘
04)┌─────────────┴─────────────┐
05)│ DataSourceExec │
06)│ -------------------- │
07)│ bytes: 3120 │
08)│ format: memory │
09)│ rows: 2 │
10)└───────────────────────────┘

# 2 Joins
query TT
explain SELECT table1.string_col, table2.date_col FROM table1 JOIN table2 ON table1.int_col = table2.int_col;
Expand Down