Migrate physical plan tests to insta (Part-1)

[Shreyaskr1409]

Which issue does this PR close?

• Part of Migrate physical plan tests to insta #15248.

The PR will become way too inconvenient to review if I implement everything in same PR.

Rationale for this change

Completely migrate physical plan tests to insta

What changes are included in this PR?

Migrating from assert_batches_sorted_eq and assert_batches_eq to assert_snapshot in physical-plan tests

Are these changes tested?

Yes

Are there any user-facing changes?

No

Additional Context

Do refer to the issue #15312 due to which I have not added migration in one test in /physical-plan/joins/hash_join.rs

[alamb]

Thanks @Shreyaskr1409 -- this seems like it has a few failing tests so I'll mark it as a draft. Please mark it when it is ready again for another look

[alamb]

Thank you so much @Shreyaskr1409 🙏

This PR looks great except for the dependency -- I think that is easy to resolve and this will be good to go.

The PR will become way too inconvenient to review if I implement everything in same PR.

Thank you so much ❤️ 🙏 🙏 🙏

[alamb]

FYI @blaginin

[blaginin]

Amazing, thank you!

Also, I noticed you have

Partially closes #15248.

in the PR body.

Just FYI, I think Github will close the issue because it has "closes #xxx" automation

[alamb]

Just FYI, I think Github will close the issue because it has "closes #xxx" automation

Good call -- I have updated the description to say "related to" rather than closes

[Shreyaskr1409]

@alamb @blaginin I have resolved all the conversations. Please look into it.
Also my bad for few unnecessary commits here and there, I am still getting acquainted with the workflow.
Thank you :)

[alamb]

@alamb @blaginin I have resolved all the conversations. Please look into it. Also my bad for few unnecessary commits here and there, I am still getting acquainted with the workflow. Thank you :)

No worries -- thanks @Shreyaskr1409

PLease don't worry about extra commits -- they are all squashed when merged to main. Multiple commits makes the history of a PR much easier to see

[alamb]

i took a look at the most recent commits and it looks good to me. Thanks again @Shreyaskr1409 !